Add more installation instructions to Readme#248
Merged
ccordoba12 merged 2 commits intopython-lsp:developfrom Aug 27, 2022
nougcat:develop
Merged
Add more installation instructions to Readme#248ccordoba12 merged 2 commits intopython-lsp:developfrom nougcat:develop
ccordoba12 merged 2 commits intopython-lsp:developfrom
nougcat:develop
Conversation
windows and linux installation instructions are now listed in readme
ccordoba12
reviewed
Aug 2, 2022
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks @nougcat for your help with this! I left some suggestions for you, otherwise looks good to me.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Contributor
Author
|
Thanks for suggestions @ccordoba12 , I added all your suggestions in the commit bd67260 Also I'm sorry for not responding to you, at the time I have committed your suggestions, I'm still learning how to collaborate with people on github. |
ccordoba12
changed the title
ccordoba12
approved these changes
Aug 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows and Linux installation instructions are now listed in readme
Fixes #245